ShanmugaKrishnanSM/RIT-nexus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(admin): wrap login endpoint in try-catch block to prevent 500 internal server error
Some checks failed
Deploy RIT Freshers Hub to VPS / Deploy to Live VPS (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Shanmuga Krishnan S M
2026-08-07 14:34:19 +05:30
parent 2f978ab244
commit a5a97b6e1a
1 changed files with 34 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
backend/src/main/java/com/rit/portal/controller/AdminController.java
View File

@@ -4,7 +4,6 @@ import org.springframework.beans.factory.annotation.Value;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.*;
import java.io.File;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
@@ -18,19 +17,18 @@ import java.util.*;
public class AdminController {
@Value("${admin.username:ritadmin}")
private String adminUsername;
private String adminUsername = "ritadmin";
@Value("${admin.password:ritadmin2026!}")
private String adminPassword;
private String adminPassword = "ritadmin2026!";
private Path getRecipientsFilePath() {
// Try VPS deployment path first, fallback to workspace relative path
Path vpsPath = Paths.get("/var/www/freshers-hub/scripts/recipients.txt");
if (Files.exists(vpsPath.getParent())) {
if (vpsPath.getParent() != null && Files.exists(vpsPath.getParent())) {
return vpsPath;
}
Path localPath = Paths.get("scripts/recipients.txt").toAbsolutePath();
if (!Files.exists(localPath.getParent())) {
if (localPath.getParent() != null && !Files.exists(localPath.getParent())) {
try {
Files.createDirectories(localPath.getParent());
} catch (IOException ignored) {}
@@ -44,6 +42,8 @@ public class AdminController {
@RequestParam(required = false) String user,
@RequestParam(required = false) String pass) {
Map<String, Object> response = new HashMap<>();
try {
String username = "";
String password = "";
@@ -54,9 +54,11 @@ public class AdminController {
if (username.isEmpty() && user != null) username = user.trim();
if (password.isEmpty() && pass != null) password = pass.trim();
Map<String, Object> response = new HashMap<>();
boolean isUsernameValid = "ritadmin".equalsIgnoreCase(username) || (adminUsername != null && adminUsername.equalsIgnoreCase(username));
boolean isPasswordValid = "ritadmin2026!".equals(password) || (adminPassword != null && adminPassword.equals(password));
String expectedUser = (adminUsername != null && !adminUsername.isEmpty()) ? adminUsername : "ritadmin";
String expectedPass = (adminPassword != null && !adminPassword.isEmpty()) ? adminPassword : "ritadmin2026!";
boolean isUsernameValid = "ritadmin".equalsIgnoreCase(username) || expectedUser.equalsIgnoreCase(username);
boolean isPasswordValid = "ritadmin2026!".equals(password) || expectedPass.equals(password);
if (isUsernameValid && isPasswordValid) {
response.put("success", true);
@@ -65,7 +67,13 @@ public class AdminController {
return ResponseEntity.ok(response);
} else {
response.put("success", false);
response.put("message", "Invalid username or password. (Expected: ritadmin / ritadmin2026!)");
response.put("message", "Invalid admin username or password");
return ResponseEntity.ok(response);
}
} catch (Exception e) {
e.printStackTrace();
response.put("success", false);
response.put("message", "Internal server error: " + e.getMessage());
return ResponseEntity.ok(response);
}
}
@@ -92,7 +100,7 @@ public class AdminController {
@PostMapping("/recipients")
public ResponseEntity<Map<String, Object>> addRecipient(@RequestBody Map<String, String> payload) {
String email = payload.get("email");
String email = payload != null ? payload.get("email") : null;
Map<String, Object> response = new HashMap<>();
if (email == null || !email.contains("@")) {